Updated as per phase II changes in event and notification config generator#136
Updated as per phase II changes in event and notification config generator#136Kandarimegha wants to merge 2 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9ac8ab7eb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| item.config | ||
| if (item.config is defined and item.config is not none) | ||
| else {'component_specific_filters': item.component_specific_filters} | ||
| if (item.component_specific_filters is defined and item.component_specific_filters is not none) |
There was a problem hiding this comment.
This new config resolution path no longer checks item.generate_all_configurations, so legacy inputs that still set generate_all_configurations: true together with component_specific_filters will now pass filters to the module instead of omitting config. In practice that silently changes a full-discovery run into a partial export, which is a behavior regression for existing playbooks/vars files that relied on the previous override semantics.
Useful? React with 👍 / 👎.
2 participants
No description provided.